-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make initAll
log a SupportError
#4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @romaricpascal
This came up in a previous comment where I thought we already logged!
Rather than two places that throw, do we need a checkSupport()
helper?
Oh, had completely missed those. I'm not sure we need a
Don't think there's a point in making the |
I'll rebase (when I get a more stable connection 😆) and see if it fixes Percy's failure. |
Mainly so stack traces go through the same throwing code, easier to mock etc. Not a blocker! |
…rted Aligns its behaviour to how the components behave, rather than silently returning
78e8e3d
to
275a24e
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 275a24e |
initAll
was still returning early silently when GOV.UK Frontend is not supported. This makes it log aSupportError
to align the message with components that throwSupportError
s in that situation.