-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rel
attribute to the Exit this Page button
#4054
Conversation
a70c083
to
b06717c
Compare
b06717c
to
5b58e9d
Compare
5b58e9d
to
73043ac
Compare
73043ac
to
5ac679b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Looking good.
I wonder if @claireashworth should sus out the changelog entry now or later. Claire, have you been reviewing other changelog entries for 5.0 before they get merged into main
?
packages/govuk-frontend/src/govuk/components/exit-this-page/template.njk
Outdated
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.yaml
Outdated
Show resolved
Hide resolved
5ac679b
to
047dd75
Compare
047dd75
to
ec24f0e
Compare
ec24f0e
to
363571b
Compare
rel
attribute to the Exit this Page button
363571b
to
e752be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny minor thing
Although we often quote attributes
keys like "data-attribute"
so not a blocker
packages/govuk-frontend/src/govuk/components/exit-this-page/template.njk
Outdated
Show resolved
Hide resolved
e752be0
to
1c7be24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're looking good. One final thing I forgot in my previous review: could we also update the child maintenance and ETP with skiplink examples so that the secondary links on those pages include the rel
improvement?
@owenatgov It is done! One of the skiplinks was missing any text, too. Fixed that while I was at it. Ooerr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
Add `rel` attribute to the Exit this Page button
Adds the
rel="nofollow noreferrer"
attribute to the Exit this Page button, so that the button:Resolves #3921.
Changes
{ 'rel': 'nofollow noreferrer' }
theattributes
parameter of thegovukButton
macro.