Add default value for warning text icon fallback attribute #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3312
owenatgov
changed the title
owenatgov
force-pushed
the
default-warning-text-icon-fallback
branch
from
cd6c502 to
e29aa85
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3312
colinrotherham
approved these changes
Feb 21, 2023
|
Does this need a changelog entry? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
Adds the default text 'Warning' to the
iconFallbackTextoption for the warning text component.As we're now setting a default value, I've also set this to no longer be a required attribute. I couldn't find any evidence in commit history that there's a risk in setting a default and not setting this as required and we use the word 'Warning' for this value in all our review app examples and our code example on the website, therefore I don't think this change is controversial.
Fixes #2693