Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loading same sound multiple times #139

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: loading same sound multiple times #139

merged 1 commit into from
Oct 17, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Oct 16, 2024

Description

When loading the same sound multiple times, an error occurred and an assert triggered.

Also modified a test to check this.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak assigned alnitak and filiph and unassigned alnitak and filiph Oct 16, 2024
@alnitak alnitak requested a review from filiph October 16, 2024 19:31
filiph
filiph approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix, and the test!

@filiph filiph merged commit f32e5ee into main Oct 17, 2024
1 check passed
@filiph filiph deleted the multiple_load branch October 17, 2024 03:47
filiph added a commit to filiph/codelabs that referenced this pull request Oct 18, 2024
@filiph
Update to version of flutter_soloud that’s guaranteed to work
6fa7a95 
This is after fix alnitak/flutter_soloud#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnitak @filiph