Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove URLs from the tasks #711

Merged
merged 6 commits into from
Feb 13, 2022
Merged

Conversation

yeganehkordi
Copy link
Contributor

@yeganehkordi yeganehkordi commented Feb 10, 2022

  • I dropped the Reference class from task375. This class refers to a reference to a source of objective evidence. It is typically a citation or a URL of a published work from a renowned source. There was only 17 instances from this class and most of them were URLs. By removing the URLs, instances were meaningless.

@danyaljj
Copy link
Contributor

Thanks @yeganehkordi!

For future PRs: let's keep them PRs relatively small so that it's easier to review.

@yeganehkordi
Copy link
Contributor Author

yeganehkordi commented Feb 13, 2022

Sure! I'll use another PR for the rest of the work.
This PR is ready to merge.

@yeganehkordi yeganehkordi changed the title remove URLs from the tasks [Work in progress] remove URLs from the tasks Feb 13, 2022
@danyaljj danyaljj merged commit 2df2d5b into allenai:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants