Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matres tasks enhancement #684

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Conversation

yeganehkordi
Copy link
Contributor

Addressing #579

@danyaljj danyaljj requested a review from Palipoor January 5, 2022 03:47
Copy link
Contributor

@Palipoor Palipoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than the two comments on the definitions.
Also, there are some " `` " characters here and there. I think it's better if we replace them with backslash + ".

@@ -11,18 +11,23 @@
"Domains": [
"News"
],
"Definition": "You will be given a context and a verb separated with a \n, and you have to answer if the given verb implies a hypothetical, or condition or not. We say a verb is hypothetical if it involves or is based on a suggested idea or theory. A verb is conditional if something is essential to the appearance or occurrence of something else. The output should be \"Yes\" if the verb is conditional or hypothetical and \"No\" otherwise.",
"Definition": "You will be given a context and a verb separated with a newline character, and you have to answer if the given verb implies a hypothetical, or condition or not. We say a verb is hypothetical if it involves or is based on a suggested idea or theory. A verb is conditional if it is in conditional sentences and something is essential to the appearance or occurrence of something else. Note that an event that happened in the past or it is happening now cannot be conditional. The output should be \"Yes\" if the verb is conditional or hypothetical and \"No\" otherwise.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition can be worded better. For example:
You will be given a context and a verb separated with a newline character. You have to decide if the given verb implies a hypothetical or conditioned action or not. We say a verb is hypothetical if it involves or is based on a suggested idea or theory. A verb is conditional if it is in a conditional sentence, and its occurrence relies on something else. Note that an event that happened in the past or is happening now cannot be conditional. The output should be \"Yes\" if the verb is conditional or hypothetical and \"No\" otherwise.

@@ -11,7 +11,7 @@
"Domains": [
"News"
],
"Definition": "You will be given a context and a verb separated with a \n, and you have to identify if the given verb implies eiher an opinion, an intention, or a wish. The output should be: 'Yes' if the verb irefers to an opinion, an intention, or a wish; and 'No' otherwise. Please note that a verb refers to an intention only if it refers to an event planned to happen in the future and is not conditional (or part of a condition).",
"Definition": "You will be given a context and a verb separated with a newline character, and you have to identify if the given verb implies eiher an opinion, an intention, or a wish. Please note that a verb refers to an intention only if it refers to an event planned to happen in the future and is not conditional (or part of a condition). The output should be: 'Yes' if the verb irefers to an opinion, an intention, or a wish; and 'No' otherwise. ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition can be worded better (the way it is now, can be vague and interpreted as if we have multiple classes: intention, opinion, wish, ...)
Something like this:
You will be given a context and a verb separated with a newline character. You have to identify verbs that imply an opinion, an intention, or a wish. Please note that a verb refers to an intention only if it refers to an event planned to happen in the future and is not conditional (or part of a condition). The output should be: 'Yes' if the verb refers to an opinion, an intention, or a wish; and 'No' otherwise.

@yeganehkordi
Copy link
Contributor Author

I updated the definitions and punctuations. I realized those punctuations were redundant, so I dropped them.

@danyaljj danyaljj merged commit ce3a08a into allenai:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants