adding input language in definition assertion #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyaljj
reviewed
Dec 12, 2021
| @@ -169,6 +169,8 @@ def natural_keys(text): | |||
| assert type(data['Input_language']) == list, f'Input_language must be a list of strings.' | |||
| assert type(data['Output_language']) == list, f'Output_language must be a list of strings.' | |||
| assert type(data['Instruction_language']) == list, f'Output_language must be a list of strings.' | |||
| assert all((lan in data['Definition']) for lan in data['Input_language'] if | |||
danyaljj
reviewed
Dec 12, 2021
| @@ -22,7 +22,7 @@ | |||
| "Instruction_language": [ | |||
| "English" | |||
| ], | |||
| "Definition": "A text is given in Malayalam. Translate it from the Malayalam language to the Tamil language. The translation must not omit or add information to the original sentence.", | |||
| "Definition": "A text is given in Tamil. Translate it from the Tamil language to the Malayalam language. The translation must not omit or add information to the original sentence.", | |||
danyaljj
reviewed
Dec 12, 2021
| @@ -17,7 +17,7 @@ | |||
| "Instruction_language": [ | |||
| "English" | |||
| ], | |||
| "Definition": "You are given a sentence in Portugese. Your job is to translate the Portugese sentence into Spanish.", | |||
| "Definition": "You are given a sentence in Portuguese. Your job is to translate the Portuguese sentence into Spanish.", | |||
danyaljj
reviewed
Dec 12, 2021
| @@ -14,7 +14,7 @@ | |||
| "Output_language": [ | |||
| "English" | |||
| ], | |||
| "Definition": "The provided file includes inquiries about restaurants in Polsih, and we ask you to translate those to English language. Please bear in mind the following guidelines while doing the translation: 1) We are looking for the most naturally written and formal form of each sentence in your language. We are *NOT* looking for colloquial forms of the sentence. We are looking for formal form which is how you would type your queries in a text-based virtual assistant. 2) The words between quotation marks *SHOULD NOT* be translated. We expect you to keep those values intact and include the quotation marks around them as well. 3) The fully capitalized words like DATE_0, or DURATION_0 *SHOULD NOT* be translated. Please keep them as they are in the translations. 4) Please do not localize measurement units like miles to kilometers during your translation. miles should be translated to its equivalent in your language. 6) Note the input is all lowercased except for fully capitalized special placeholders (e.g. NUMBER, DATE, TIME). Please do the same in your translations.", | |||
| "Definition": "The provided file includes inquiries about restaurants in Polish, and we ask you to translate those to English language. Please bear in mind the following guidelines while doing the translation: 1) We are looking for the most naturally written and formal form of each sentence in your language. We are *NOT* looking for colloquial forms of the sentence. We are looking for formal form which is how you would type your queries in a text-based virtual assistant. 2) The words between quotation marks *SHOULD NOT* be translated. We expect you to keep those values intact and include the quotation marks around them as well. 3) The fully capitalized words like DATE_0, or DURATION_0 *SHOULD NOT* be translated. Please keep them as they are in the translations. 4) Please do not localize measurement units like miles to kilometers during your translation. miles should be translated to its equivalent in your language. 6) Note the input is all lowercased except for fully capitalized special placeholders (e.g. NUMBER, DATE, TIME). Please do the same in your translations.", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #677
added the assertion @danyaljj and had to change a few tasks so the tests could pass. Although I don't know how useful this assertion could be.