Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks 1443 - 1446: Synthetic data #449

Merged
merged 9 commits into from
Oct 20, 2021
Merged

Conversation

kurbster
Copy link
Contributor

No description provided.

Copy link
Contributor

@yeganehkordi yeganehkordi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. Some minor comments:

  • Please update the categories and add domain field based on the task-hierarchy.
  • I think it's better to change 1,726 in the definition of task 1443 to 1726, as you have mentioned that no commas or any other characters should be included in the output.

@kurbster
Copy link
Contributor Author

@yeganehkordi What is the list of domains? For tasks 1444-1446 I put the domain as mathematics as those tasks involve rounding, and subtraction. But what should I put for task 1443? It does not really involve mathematics simply parsing strings into numbers.

I have made the change by removing the comma and I will push that once I add the domain to 1443. Thank you!

@kurbster
Copy link
Contributor Author

I found the list of Domains, I am still unsure what to use for task 1443. Maybe mathematics?

@yeganehkordi
Copy link
Contributor

Thanks! Yeah, I think mathematics is the best match.

@swarooprm swarooprm merged commit 0c63b3b into allenai:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants