-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks 1407-1417: DART, ajgt_twitter_ar, and youtube_caption_corrections. #429
Conversation
Please make sure to set the |
@Mehrad0711, wondering if you can help review these tasks? |
Things look good in general. Although, I have some suggestions:
"The input is a list of triplets of the form [subject, predicate, object] and the output is a list of questions that are sentences based on the triplets but with the subject and/or object replaced with slots." Probably add a line that says: "All input triplets need not be used in the question for it to be valid."
I noticed input triplets like this:
|
@RushangKaria, could you update your files based on reviewer comments? |
Hi @swarooprm Yes, ill make the necessary changes and push a new set of changes. Thanks for the reviews! |
@RushangKaria, a gentle reminder! |
@swarooprm Sorry, got caught up in some other stuff. Should have an update soon. |
Made the changes. Some files have no matching or relevant domain so I've left those unchanged (without a domain). |
Thanks for making the changes. LGTM now! |
@RushangKaria, can you rename the files to 1407-1417 so that we can go ahead and merge this PR? |
Hi @swarooprm, Yes, Ill rename the files and create a new PR for it. |
Renamed the files in PR allenai#429 to match the reserved filenames. This PR only changes the filenames from allenai#429.
Created a set of tasks from the DART, ajgt_twitter_ar and youtube_caption_corrections datasets available on huggingface.
Tasks