Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing several outstanding issues #38

Merged
merged 7 commits into from
Jul 24, 2021
Merged

Fixing several outstanding issues #38

merged 7 commits into from
Jul 24, 2021

Conversation

danyaljj
Copy link
Contributor

@danyaljj danyaljj marked this pull request as draft July 22, 2021 20:12
@danyaljj danyaljj changed the title Work in progress Fixing several outstanding issues Jul 22, 2021
@danyaljj danyaljj marked this pull request as ready for review July 22, 2021 20:58
@danyaljj
Copy link
Contributor Author

Until we address the issues in issue #39 this is going to fail.

@swarooprm
Copy link
Contributor

swarooprm commented Jul 24, 2021 •
edited
Loading

All issues in #39 seems to be addressed now
.

@danyaljj
Copy link
Contributor Author

Sounds good! Looks like the added tests are passing now.
@swarooprm give it a review and merge, if it looks good.

swarooprm
swarooprm approved these changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@swarooprm swarooprm merged commit 54d2985 into master Jul 24, 2021
This was referenced Jul 24, 2021
Closed
Closed
@danyaljj danyaljj deleted the augmented-tests branch September 16, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swarooprm swarooprm swarooprm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyaljj @swarooprm