Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task 224 #137

Merged
merged 4 commits into from
Sep 1, 2021
Merged

task 224 #137

merged 4 commits into from
Sep 1, 2021

Conversation

amirrezamirzaei
Copy link
Contributor

task 224 using scruples Anecdotes dataset.

@danyaljj
Copy link
Contributor

Thanks! Minor suggestions below; otherwise it looks good to me.

  • "anecdote. each anecdote " -> "anecdote, which ..."
  • "is ethically" -> has acted ethically?

For future PRs: we used to follow "Emphasis & Caution:" and "Things to avoid" in the past; but since a while ago, we have decided to deviate from this rule and use the natural structure/phrasing of the tasks (i.e., just state the task as-is, without adding such artificial structures).

@danyaljj danyaljj requested a review from swarooprm August 29, 2021 00:04
@danyaljj
Copy link
Contributor

Thanks! Looks good to me!

Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Merging.
Also, consider creating more tasks from the scruples dataset.

@swarooprm swarooprm merged commit 328e005 into allenai:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants