Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task-223: QuaRTz #136

Merged
merged 16 commits into from
Sep 2, 2021
Merged

Task-223: QuaRTz #136

merged 16 commits into from
Sep 2, 2021

Conversation

Mirzyaaliii
Copy link
Contributor

Another task from the QuaRTz dataset - Task223_QuaRTz_explanation_generation

Please review.

@danyaljj
Copy link
Contributor

danyaljj commented Aug 29, 2021

Looks good!

For the QA task, it would be helpful to say that one should write the answer string (as opposed to "option 1/2").

Otherwise, it looks good to me!

@danyaljj danyaljj requested a review from swarooprm August 29, 2021 01:21
@swarooprm
Copy link
Contributor

Looks good to me. Please do git pull so that the conflict gets resolved. I will then be able to approve and merge PR.

@swarooprm
Copy link
Contributor

I am not able to resolve conflict here, you need to do 'git pull' to resolve conflicts.

Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging.

@swarooprm swarooprm merged commit 9d53ee9 into allenai:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants