Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks 171-175 #108

Merged
merged 8 commits into from
Sep 1, 2021
Merged

Add tasks 171-175 #108

merged 8 commits into from
Sep 1, 2021

Conversation

Mehrad0711
Copy link
Contributor

Adding more datasets from SPL project

@danyaljj
Copy link
Contributor

Thanks!

Now that we're adding more tasks for other languages, wondering if you can help us address #113, before we merge this PR.

@eshaanpathak
Copy link
Contributor

Can't these MT tasks also go the other way around? For example, Spanish to English too.

@Mehrad0711
Copy link
Contributor Author

Hi @danyaljj,
Thanks for your suggestion! I added input/ output language tags for the SPL tasks.
Please let me know if there's anything else.

@Mehrad0711
Copy link
Contributor Author

Can't these MT tasks also go the other way around? For example, Spanish to English too.

Yes. The sentences are actually aligned between languages so you can go from any source language to any target language within the 11 languages supported. There are 2 domains in SPL so there will be a total of 220 tasks. After adding all tasks with English sources, I can continue adding other directions if the main authors think this is indeed a good addition.

CC: @danyaljj, @swarooprm

@danyaljj
Copy link
Contributor

Looks good to me, thanks!

After adding all tasks with English sources, I can continue adding other directions if the main authors think this is indeed a good addition.

Sure we would be happy to see them in future PRs,!

@danyaljj danyaljj requested a review from swarooprm August 31, 2021 15:44
Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
[minor comment]: Define "special placeholders" like you have defined other terms.

Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!
Looking forward to more such tasks in reverse and other languages as you have mentioned in your comment.

@swarooprm
Copy link
Contributor

Updated Readme to resolve merge conflicts.

@swarooprm swarooprm merged commit d40d553 into allenai:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants