-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tasks 171-175 #108
Add tasks 171-175 #108
Conversation
Thanks! Now that we're adding more tasks for other languages, wondering if you can help us address #113, before we merge this PR. |
Can't these MT tasks also go the other way around? For example, Spanish to English too. |
Hi @danyaljj, |
Yes. The sentences are actually aligned between languages so you can go from any source language to any target language within the 11 languages supported. There are 2 domains in SPL so there will be a total of 220 tasks. After adding all tasks with English sources, I can continue adding other directions if the main authors think this is indeed a good addition. CC: @danyaljj, @swarooprm |
Looks good to me, thanks!
Sure we would be happy to see them in future PRs,! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[minor comment]: Define "special placeholders" like you have defined other terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging!
Looking forward to more such tasks in reverse and other languages as you have mentioned in your comment.
Updated Readme to resolve merge conflicts. |
Adding more datasets from SPL project