Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 164-165: MCScript #105

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Task 164-165: MCScript #105

merged 6 commits into from
Aug 23, 2021

Conversation

Mirzyaaliii
Copy link
Contributor

Task 164 - task164_MCScript_question_answering_text
Task 165 - task165_MCScript_question_answering_commonsense

Please review.

@danyaljj
Copy link
Contributor

Thanks!

Mention that the string of the correct answer needs to be returned (not "Option 1/2").

@Mirzyaaliii
Copy link
Contributor Author

Please review again.

danyaljj
danyaljj approved these changes Aug 21, 2021
View reviewed changes
Copy link
Contributor

@danyaljj danyaljj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danyaljj danyaljj requested a review from swarooprm August 21, 2021 13:30
@swarooprm swarooprm merged commit c0ede88 into allenai:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swarooprm swarooprm swarooprm approved these changes

@danyaljj danyaljj danyaljj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mirzyaaliii @danyaljj @swarooprm