This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Update cached_path version #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Jun 13, 2022
epwalsh
approved these changes
Jun 17, 2022
tests/common/file_utils_test.py
Outdated
| extracted = cached_path(url, cache_dir=self.TEST_DIR, extract_archive=True) | ||
| assert extracted.endswith("-extracted") | ||
| self.check_extracted(extracted) | ||
| # @responses.activate |
There was a problem hiding this comment.
Could also just @pytest.skip(reason="whatever")
There was a problem hiding this comment.
Ah, yes, that's better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pip-toolsto resolve versions of primary and non-primary dependencies, so that we don't download multiple versions of multiple packages.venvinstead ofconda, which was several times slower.pip-tools) has reduced the virtual environment caching time from hours (we stopped trying after 1 hour) to ~5 min.cached-path, and then uncommented.