-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
Hey @MSLars, thanks for taking this. Are you still having an issue running tests? Also, could you update the CHANGELOG when you get a chance? |
@epwalsh I updates the Changelog. I still have the issue with running
which leads to
But I seem to have the same problem for each test with When I execute
The same test as before runs without errors. So I guess its an issue with my development configuration and the code should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @MSLars, thank you! I just left a few minor comments.
tests/modules/span_extractors/max_pooling_span_extractor_test.py
Outdated
Show resolved
Hide resolved
tests/modules/span_extractors/max_pooling_span_extractor_test.py
Outdated
Show resolved
Hide resolved
tests/modules/span_extractors/max_pooling_span_extractor_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @MSLars!
Closes #5449.
Changes proposed in this pull request:
MaxPoolingSpanExtractor
. This components represents spans via a max-pooling operation.Before submitting
section of the
CONTRIBUTING
docs.I received an Error
E RuntimeError: function '_has_torch_function' already has a docstring
when I execute
to calculate the test coverage.
Writing docstrings section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.