This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Registrable _to_params default functionality #5403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5367 .
Changes proposed in this pull request:
_to_params
method ofRegistrable
so that in the case it is not implemented by the child class, it will still produce a parameter dictionary._to_params
implementations to all tokenizers.The motivation for this PR is that currently, almost every Registrable does not have an implementation of
_to_params
and thus will raise aNotImplementedError
when trying to populate a config with parameters. Thus, adding minimal functionality to the Registrable class avoids this error.It is not the cleanest solution and implementing the
_to_params
method for all classes would be better, but also time-consuming.Before submitting
I've read and followed all steps in the Making a pull request
section of the
CONTRIBUTING
docs.I've updated or added any relevant docstrings following the syntax described in the
Writing docstrings section of the
CONTRIBUTING
docs.If this PR fixes a bug, I've added a test that will fail without my fix.
If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.
After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.