Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Registrable _to_params default functionality #5403

Merged
merged 11 commits into from
Oct 8, 2021

Conversation

gabeorlanski
Copy link
Contributor

@gabeorlanski gabeorlanski commented Sep 10, 2021

Fixes #5367 .

Changes proposed in this pull request:

  • Added in a default behavior to the _to_params method of Registrable so that in the case it is not implemented by the child class, it will still produce a parameter dictionary.
  • Added in _to_params implementations to all tokenizers.

The motivation for this PR is that currently, almost every Registrable does not have an implementation of _to_params and thus will raise a NotImplementedError when trying to populate a config with parameters. Thus, adding minimal functionality to the Registrable class avoids this error.

It is not the cleanest solution and implementing the _to_params method for all classes would be better, but also time-consuming.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.

  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.

  • If this PR fixes a bug, I've added a test that will fail without my fix.

  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@gabeorlanski gabeorlanski changed the title Registrable to params Registrable _to_params default functionality Sep 10, 2021
@AkshitaB AkshitaB self-requested a review September 24, 2021 22:03
@AkshitaB AkshitaB merged commit 362349b into allenai:main Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate the Config with default values before saving
2 participants