Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

require Python>=3.7 #5400

Merged
merged 2 commits into from
Sep 8, 2021
Merged

require Python>=3.7 #5400

merged 2 commits into from
Sep 8, 2021

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Sep 7, 2021

Fixes #5398.

Changes proposed in this pull request:

  • Changes setup.py to require Python >= 3.7.

@AkshitaB AkshitaB self-requested a review September 8, 2021 18:39
AkshitaB
AkshitaB approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@AkshitaB AkshitaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need a corresponding PR for the models repo too, right?

@epwalsh
Copy link
Member Author

epwalsh commented Sep 8, 2021

We need a corresponding PR for the models repo too, right?

yes, good point. I'll follow up.

@epwalsh epwalsh mentioned this pull request Sep 8, 2021
Merged
@AkshitaB AkshitaB merged commit 527e43d into main Sep 8, 2021
@AkshitaB AkshitaB deleted the python-requirement branch September 8, 2021 21:03
@epwalsh epwalsh mentioned this pull request Dec 23, 2021
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AkshitaB AkshitaB AkshitaB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OrderedDict typing breaks compatibility with Python 3.6
2 participants
@epwalsh @AkshitaB