This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
improve signal handling and worker cleanup #5378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5369. @dhruvdcoder could you please take a look and verify that this fixes your issues?
Changes proposed in this pull request:
allennlp
will now catchSIGTERM
signals and handle them the same way ofSIGINT
(keyboard interrupt).MultiProcessDataLoader
will properly shutdown its workers when aSIGTERM
is received.MultiProcessDataLoader
workers to constantly check if the main process is still alive and consuming. If they determine that the main process has exited, they can shut themselves down. This is useful if the main process exits abnormally. But unfortunately it only works whenstart_method
is "spawn".Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.