Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Use our own base images to build allennlp Docker images #5366

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Aug 18, 2021

Base images are built here: /~https://github.com/allenai/docker-images.

I posted a blurb about this in the #engineering channel on Slack:

In an effort to speed up Docker builds across our projects and strongly version base images to avoid the possibility of downstream images breaking due to unanticipated changes in those base images, I’ve made this repo (/~https://github.com/allenai/docker-images) for building useful base images. So far I’ve just added base images for pytorch which we’ll end up using downstream in the AllenNLP ecosystem, but it’s easy to add new ones (instructions in the readme).

@epwalsh epwalsh requested review from dirkgr and AkshitaB August 18, 2021 17:09
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of running off of our own Docker images, rather than official ones?

@epwalsh
Copy link
Member Author

epwalsh commented Aug 18, 2021

What's the advantage of running off of our own Docker images, rather than official ones?

Mainly versioning. We control when we update the base images and how we version them (see /~https://github.com/allenai/docker-images#image-versioning), so we don't get blindsided by an unexpected change.

@epwalsh epwalsh enabled auto-merge (squash) August 19, 2021 17:45
@epwalsh epwalsh merged commit 1f5c6e5 into main Aug 19, 2021
@epwalsh epwalsh deleted the base-image branch August 19, 2021 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants