Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix ConfigurationError deserialization #5319

Merged
merged 5 commits into from
Jul 23, 2021

Conversation

ojomio
Copy link
Contributor

@ojomio ojomio commented Jul 18, 2021

Fixes #5318 .

Changes proposed in this pull request:

  • Overrides BaseException.__reduce__() to include message value in the args passed down to cls(which in turn calls __new__ and then __init__)

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epwalsh epwalsh enabled auto-merge (squash) July 19, 2021 21:40
@epwalsh
Copy link
Member

epwalsh commented Jul 19, 2021

Looks like you're missing an import of pickle in the test though.

@ojomio ojomio marked this pull request as draft July 19, 2021 22:18
auto-merge was automatically disabled July 19, 2021 22:18

Pull request was converted to draft

@dirkgr dirkgr marked this pull request as ready for review July 23, 2021 17:53
@dirkgr dirkgr merged commit 67add9d into allenai:main Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigurationError exception is not deserializable
3 participants