This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Update links in initializers documentation #5317
Merged
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himkt
commented
Jul 18, 2021
| * ["constant"](https://pytorch.org/docs/master/nn.init.html?highlight=orthogonal#torch.nn.init.constant_) | ||
| * ["eye"](https://pytorch.org/docs/master/nn.init.html?highlight=orthogonal#torch.nn.init.eye_) | ||
| * ["dirac"](https://pytorch.org/docs/master/nn.init.html?highlight=orthogonal#torch.nn.init.dirac_) | ||
| * ["xavier_uniform"](https://pytorch.org/docs/master/nn.init.html?highlight=orthogonal#torch.nn.init.xavier_uniform_) |
There was a problem hiding this comment.
The length of the line exceeds 115... 💭
There was a problem hiding this comment.
You could just add a # noqa: E501 comment to the end of this docstring. For example, see
There was a problem hiding this comment.
It makes sense! I added the comment in e565dcf.
epwalsh
reviewed
Jul 19, 2021
himkt
force-pushed
the
bugfix/broken-link
branch
from
c564e2a to
e565dcf
Compare
himkt
force-pushed
the
bugfix/broken-link
branch
from
e565dcf to
58f0bdc
Compare
epwalsh
approved these changes
Jul 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some links in the initializer documentation were broken.
This PR updates them to fix.
Before submitting
section of the
CONTRIBUTINGdocs.I've updated or added any relevant docstrings following the syntax described in theWriting docstrings section of the
CONTRIBUTINGdocs.If this PR fixes a bug, I've added a test that will fail without my fix.If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.