Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Making model test case consistently random #5278

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

jacob-morrison
Copy link
Contributor

@jacob-morrison jacob-morrison commented Jun 22, 2021

Changes proposed in this pull request:

  • Making model_test_case.ensure_model_can_train_save_and_load consistently random

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@jacob-morrison jacob-morrison requested a review from dirkgr June 22, 2021 21:15
@jacob-morrison jacob-morrison marked this pull request as ready for review June 22, 2021 21:15
@dirkgr dirkgr merged commit 86504e6 into main Jun 22, 2021
@dirkgr dirkgr deleted the change-mode-test-case branch June 22, 2021 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants