This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Removes confusing zero mask from VilBERT #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-morrison
suggested changes
Jun 15, 2021
There was a problem hiding this comment.
I think we'll have problems in the bimodal encoder if we don't pass in the mask: /~https://github.com/allenai/allennlp/blob/main/allennlp/modules/transformer/bimodal_encoder.py#L194-L199. I think the problem is actually in the encoder though (ie we should still delete this useless mask in the backbone), because co_attention_mask's default value is None, but I'm pretty sure these lines will break if it is None.
|
I think that fixes it, but let's see what the tests say. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while trolling through @jacob-morrison's code. That mask is unused later. If it were used, it would be wrong.