This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Skip ETag check if OSError #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Jul 13, 2020
|
Done :) |
epwalsh
reviewed
Jul 13, 2020
|
Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion here, attempts to fix an issue that was preventing
cached_pathfrom being used to download files from GitHub releases.It looks like ETags are optional, so I elected to just catch the
OSErrorthat is thrown by_http_etagand setetag = Nonein this case (url_to_filenamealready supports an unspecifiedetag). This solution seems cleaner to me than asking the user to provide some flag to skip the ETag fetch.Let me know if you are happy with this solution and then I can try to write a unit test for this scenario / update the
CHANGELOG.md.