This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add a method to ModelTestCase for use without config files #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
Jun 19, 2020
| the `Trainer` object itself, and grab the `Model` and other necessary objects from there. | ||
|
|
||
| # Parameters | ||
|
|
There was a problem hiding this comment.
Thanks, good catch.
epwalsh
approved these changes
Jun 19, 2020
|
@epwalsh, this is now failing docs builds, and I am having a really hard time figuring out what the offending line is. Any help? Is there a way to have the scripts actually output the line that's the problem? |
|
That’s weird, I’ve never seen that before. I’ll try to debug that on Monday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary to have tests for the no-config-file template repo. I also noticed a few other small typos in the documentation, which are fixed in here.