Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add link to new template repo for config file development #4372

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

matt-gardner
Copy link
Contributor

@matt-gardner matt-gardner commented Jun 17, 2020

Partial fix for #4339. Not saying it closes that issue, because there are two more templates to make first.

If you're interested in using AllenNLP for model development, we recommend you check out the
[AllenNLP Guide](https://guide.allennlp.org). When you're ready to start your project, we've
created a template repository that you can use as a starting place:
/~https://github.com/allenai/allennlp-template-config-files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on making two more template repositories, one for development using your own script instead of allennlp train, and one for doing that along with using pytorch lightning as your trainer, instead of the allennlp trainer. Then this will be a list, instead of a single link.

@matt-gardner matt-gardner requested a review from epwalsh June 17, 2020 23:24
@matt-gardner
Copy link
Contributor Author

Did you look at the template repo at all? Any comments on it?

@epwalsh
Copy link
Member

epwalsh commented Jun 18, 2020

Do you think it's worth adding a dev-requirements.txt file with at least pytest in it?

@matt-gardner
Copy link
Contributor Author

Hmm, for a template like this, having two requirements files seems like overkill, but yeah, I'll add a bit more there about pytest. I think I forgot to say how to run the tests, and I'll add pytest to requirements.txt. Thanks!

@matt-gardner matt-gardner merged commit 3e8a9ef into allenai:master Jun 18, 2020
@matt-gardner matt-gardner deleted the add_config_template branch June 18, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants