Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

fix file utils test #4349

Merged
merged 1 commit into from
Jun 10, 2020
Merged

fix file utils test #4349

merged 1 commit into from
Jun 10, 2020

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Jun 10, 2020

No description provided.

@epwalsh epwalsh requested review from schmmd and matt-gardner June 10, 2020 18:32
@epwalsh
Copy link
Member Author

epwalsh commented Jun 10, 2020

Since @dirkgr is probably asleep and this is blocking other PRs, could one of you (@schmmd or @matt-gardner) review this?

schmmd
schmmd approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@schmmd schmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward if it's a blocker...

@epwalsh epwalsh merged commit 33d0cd8 into allenai:master Jun 10, 2020
@epwalsh epwalsh deleted the fix-file-utils-test branch June 10, 2020 19:36
dirkgr
dirkgr reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually don't care so much why this didn't break before.

@dirkgr
Copy link
Member

dirkgr commented Jun 10, 2020

Looks like I was too late :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr left review comments

@schmmd schmmd schmmd approved these changes

@matt-gardner matt-gardner Awaiting requested review from matt-gardner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwalsh @dirkgr @schmmd