This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
add missing param threshold_mode
#4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2020 18:19
epwalsh
approved these changes
Apr 30, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably a bug.
I see
threshold_modeas a param of__init__ofReduceOnPlateauLearningRateScheduler, but it misses in the initializer oftorch.optim.lr_scheduler.ReduceLROnPlateau.I found this problem in my experiment, by observing exceptional learning rate decay, and further found that the
threshold_modeofReduceOnPlateauLearningRateScheduler.lr_scheduleris always equal to "rel", even I had setthreshold_mode = 'abs'.If this is not intended, then it's probably an oversight.