This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
tweak torch requirement #4166
Merged
tweak torch requirement #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryant1410
reviewed
Apr 29, 2020
setup.py
Outdated
| @@ -50,7 +50,7 @@ | |||
| license="Apache", | |||
| packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | |||
| install_requires=[ | |||
| "torch>1.3.1,<=1.5.0", | |||
| "torch>1.3.1,<1.5.1", | |||
There was a problem hiding this comment.
What about <1.6.0? PyTorch "patch" version changes shouldn't be breaking. But maybe you think it's better to have them CI-tested anyway?
There was a problem hiding this comment.
Our CI will always test against the newest allowed package, so we'd know right away if a new patch version breaks anything. So yea, I agree with you, we should make it <1.6.0
dirkgr
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is the
setup.pyrequirestorch>1.3.1,<=1.5.0. But this excludes version1.5.0+cu101which is needed if you have cuda 10.1 and not cuda 10.2. So - as I found out today - if you have1.5.0+cu101installed and you try running anallennlpcommand it will completely fail with this: