This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Push 'latest' tag versions of Docker images #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmmd
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
I think it's bad to use latest in general so I'm not sure I agree that it's always good to have a latest branch.
But if it's useful for caching (which is exactly what Sam and I used it for in the Skiff builds) then let's go for it! Just beware that the caching won't be effective for PRs that are quite divergent. For example, if I made a PR that changed the base image this cache wouldn't help at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's good to always have a 'latest' tag. I was also going to try Docker layer caching here but I think I'll put that in another PR.