This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Minor fixes so PretrainedTransformerIndexer works with roberta #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgrus
approved these changes
Aug 27, 2019
nelson-liu
reviewed
Aug 27, 2019
| @@ -51,6 +51,8 @@ def __init__(self, | |||
| self.tokenizer = AutoTokenizer.from_pretrained(model_name, do_lower_case=do_lowercase) | |||
There was a problem hiding this comment.
So I'm trying this PR out, and in the case where model name isn't loadable from AutoTokenizer.from_pretrained, it returns None. Maybe consider catching that and throwing a more informative error message here? (instead, it errors when you try to use self.tokenizer to get the id of the token.
There was a problem hiding this comment.
SGTM, PR welcome.
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You currently need to manually install
pytorch-transformersfrom master, because there is no released version that includes roberta in theAutoTokenizerand such. But this makes the indexer compatible with roberta.