This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Modified ActionSpaceWalker to use DomainLanguage #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Jun 25, 2019
| @@ -20,7 +20,7 @@ | |||
| from allennlp.data.tokenizers.word_splitter import SpacyWordSplitter | |||
| from allennlp.data.token_indexers import SingleIdTokenIndexer | |||
| from allennlp.data.token_indexers.token_indexer import TokenIndexer | |||
| from allennlp.semparse import ParsingError | |||
| from allennlp.semparse.domain_languages import ParsingError | |||
There was a problem hiding this comment.
Isn't this imported at the module level? If it's not, it should be, so this line shouldn't need to be changed.
| for next_set in filtered_path_indices[1:]: | ||
| return_set = return_set.intersection(next_set) | ||
| paths = [self._completed_paths[index] for index in return_set] | ||
| index_to_num_items: Dict[int, int] = defaultdict(int) |
There was a problem hiding this comment.
This logic is pretty hard to follow without comments explaining what's going on.
Whu-wxy
added a commit
to Whu-wxy/allennlp
that referenced
this pull request
Jun 26, 2019
Modified ActionSpaceWalker to use DomainLanguage (allenai#3006)
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* moved action space walker and lf search script from iterative search * action space walker uses DomainLanguage * modified script for searching nlvr logical forms * addressed PR comments * mypy fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved the script used for searching for logical forms for WTQ from iterative-search-semparse.