This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Lr scheduler bug #2905
Merged
Lr scheduler bug #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
May 31, 2019
|
Is it okay for it to be a logger warning when the metrics and mode don't agree in update_scheduler_params (allennlp/training/util.py, line 455), or should that be a configuration Error ? |
|
@DeNeutoy, is this good to merge? |
|
@DeNeutoy ping. Thanks. |
|
@codedecde , sorry for letting this slip through the cracks. I've given this another skim and based on that plus @DeNeutoy's previous approval I'm going to merge. Regarding your specific question on the configuration error/warning distinction (allennlp/training/util.py, line 455), I'd be partial to a hard error, but I don't think that needs to hold up merging this PR. Feel free to add that in a followup PR if you feel strongly. Thanks for your contribution! |
Whu-wxy
added a commit
to Whu-wxy/allennlp
that referenced
this pull request
Jul 13, 2019
Lr scheduler bug (allenai#2905)
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
Fixes allenai#2895 Couple of things that I would like to discuss - Currently, the design makes it necessary to specify the mode while using the reduce_on_plateau scheduler, unless its specified in a trainer (in which case the mode is set automatically, based on the validation metric) - If the metric and the mode do not match, currently the code uses a logger.warning instead of an exception. Can change that to be an exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895
Couple of things that I would like to discuss