WIP: Add http trigger support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tanhe123
force-pushed
the
add_http_trigger_support
branch
2 times, most recently
from
703c06c to
c2c1d23
Compare
tanhe123
force-pushed
the
add_http_trigger_support
branch
from
69fcf6e to
e64ea48
Compare
tanhe123
force-pushed
the
add_http_trigger_support
branch
from
e64ea48 to
1a561aa
Compare
| @@ -42,6 +42,8 @@ | |||
| import com.aliyuncs.fc.model.PrepareUrl; | |||
| import com.aliyuncs.fc.utils.ParameterHelper; | |||
|
|
|||
| import static com.google.common.base.Strings.isNullOrEmpty; | |||
There was a problem hiding this comment.
let's group the imports
| @@ -37,13 +37,17 @@ | |||
| public HttpResponse() { | |||
| } | |||
|
|
|||
| public void putHeaderParameter(String key, String value) { | |||
| public void setHeader(String key, String value) { | |||
There was a problem hiding this comment.
Is this a breaking change?
There was a problem hiding this comment.
是的，这是一个 breaking change，但是我觉得有必要修改：
- 引入 http trigger 前，用户没有任何需求会调用 header 相关的方法，所以这个改动没有影响。
- 原有的方法名 putHeaderParameter、getHeaderValue，我觉得表意不明，我改成了 getHeader、setHeader，我觉得有必要。
必要的原因是，另外一个 breaking change：
我们有两组重复的方法
setHeader(Map<String, String> header)
Map<String, String> getHeader()
setHeaders(Map<String, String> header)
Map<String, String> getHeaders()
每组的状态是不一致的，意思是通过 setHeader 设置的值，getHeader 可以取到，getHeaders 取不到，我觉得也有必要修改，所以我删掉了原有的 getHeader、setHeader。将其修改为 getHeaderValue、putHeaderParameter 的语义。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.