-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First PR into main #4
Conversation
docs: sphinx, autodoc2, doctests setup
@PhearZero can you review this to verify the CD setup looks good. PRs into PRs into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joe-p ran a few dry runs and merges locally and it seems good to go configuration wise 🎉. (it may need to disallow version zero to match the correct semantics )
The only two things I can see in the actions:
-
Right now the cd action is set to be manually triggered and I couldn't find a dispatcher. May want to add a dedicated action that dispatches the
cd
action with opinions likedry_run:false
on push tomain
andrelease/*
. -
Not sure if this is valid but the
gh-action-pypi-publish
has the package url in the documentation as a ENV variable. Do you know if that is optional @aorumbayev ?
Ah good catch. How much do we value manual dispatches? We can setup a reusable workflow that can be dispatched and on push, but probably simpler to just change this workflow to on push only, otherwise we need to redefine inputs on |
+1 for changing it to We may find a good reason to abstract it into it's own workflow/action at a later date, (I know it's been useful for MakerX) |
Ok I've updated the CD workflow to essentially do everything except docs on both branches. Docs will only get published on stable releases. We'll probably want to think about how/if we do docs for historical versions, but not a priority for now. Edit: Also set |
We should sync with @aorumbayev and @SilentRhetoric, I've talked a bit with both of them on documentation generation. The Edit: LGTM |
|
||
## Quick start | ||
|
||
```{testcode} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PhearZero thats the example of a doctest using https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html. In case remaining docs need to use them, should be a matter of replacing python
with testcode
to make them runnable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged into
main
abeta
release should be triggered. Once everything is confirmed working, we can merge frommain
intorelease/1.x
to trigger the first stable release.