This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Display all device events #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Need handling of custom events - Need better handling of namedays
…r it was asked for
The PeopleEventsContentProvider was doing too much. - It used to validate the query arguments passed so that it matches the only query - It modified the arguments passed so that we always returned the correct date - It was not flexible at all Overall that was more of a hack than a proper implementation. This commit makes the provider just query the events and it's up to the caller to perform the correct parameters.
* develop: Remove all google-services files Update README.md
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the ability to display any kind of Android supported event. Additionally, it in this PR we are storing in the database all static events and calculate on the fly dynamic events such as Special cases of Namedays. This allow us to be able to display the events of any possible date we want instead of having to limit into the database stored events.
Test(s) added
added plenty, modified others
Screenshots
Coming soon.