This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Use only alphanumeric characters for Firebase event names #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alexstyl
added a commit
that referenced
this pull request
Jul 4, 2020
Use only alphanumeric characters for Firebase event names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the FirebaseAnalytics.Event documentation, the events can only contain alphanumeric characters and must not exceed 32. This check is not done by the framework. This PR "fixes" the names of all events and makes sure that all events are created according to the rules
Test(s) added
yes. Around the Rules described in the documentation.