Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airship interacting with generic container hangs #513

Closed
teoyaomiqui opened this issue Apr 5, 2021 · 1 comment
Closed

Airship interacting with generic container hangs #513

teoyaomiqui opened this issue Apr 5, 2021 · 1 comment
Assignees
@teoyaomiqui
Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size m
Milestone
v2.1

Comments

@teoyaomiqui
Copy link
Contributor

Describe the bug
Sometimes airshipctl would hang indefinitely without actually starting the docker container.

Steps To Reproduce
The bug is floating, and it seems to be working, however, sometimes it hags.

Create a phase with the executor of type airship:

---
apiVersion: airshipit.org/v1alpha1
kind: GenericContainer
metadata:
  name: kubectl-wait-node
  labels:
    airshipit.org/deploy-k8s: "false"
spec:
  image: quay.io/airshipit/toolbox:latest
  hostNetwork: true
configRef:
  kind: ConfigMap
  name: kubectl-wait-node
---
apiVersion: airshipit.org/v1alpha1
kind: Phase
metadata:
  name: kubectl-wait-node-ephemeral
  clusterName: ephemeral-cluster
config:
  executorRef:
    apiVersion: airshipit.org/v1alpha1
    kind: GenericContainer
    name: kubectl-wait-node
  documentEntryPoint: ephemeral/initinfra-networking

run the phase:

# airshipctl phase run kubectl-wait-node-ephemeral

Expected behavior
airshipctl tries to execute script specified in kubectl-wait-node ConfigMap

Actual behavior
airshipctl hangs indefinitely

Environment

  • airshipctl Version: v2.0
  • Operating System: Ubuntu 20.04
  • Kernel version: 5.4.0-70-generic
  • Kubernetes Version: 1.19
  • Go version: 1.13
  • Hardware specs (e.g. 4 vCPUs, 16GB RAM, bare metal vs VM): VM with 2 CPU and 8 GB
@teoyaomiqui teoyaomiqui added bug Something isn't working triage Needs evaluation by project members labels Apr 5, 2021
@teoyaomiqui teoyaomiqui self-assigned this Apr 5, 2021
@jezogwza jezogwza changed the title Airship container hangs Airship interacting with generic container hangs Apr 7, 2021
@jezogwza jezogwza added priority/critical Items critical to be implemented, usually by the next release and removed triage Needs evaluation by project members labels Apr 7, 2021
@jezogwza jezogwza added this to the v2.1 milestone Apr 7, 2021
airshipbot pushed a commit that referenced this issue Apr 7, 2021
@teoyaomiqui
Fix docker stdin write.
7c9dd85 
Without this commit airship can hang endlessly waiting for stdin
to be open. Apparently it depends on the containerd and docker
server version. This commit adds asnyc writing to stdin, this way
we don't have to wait for write to complete before starting docker
container. The code uses similar approach to upstream docker cli
implementation.

Related-To: #513

Change-Id: I2e6d4cbe37df1f8cba356af79c1c2cf18438e86c
@teoyaomiqui
Copy link
Contributor Author

The issue was fixed by the merged patchset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teoyaomiqui teoyaomiqui

Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size m
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
2 participants
@jezogwza @teoyaomiqui