-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky websocket test #7902
Fix flaky websocket test #7902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7902 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 107 107
Lines 32246 32247 +1
Branches 3750 3750
=======================================
+ Hits 31410 31411 +1
Misses 632 632
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 28d0b06 on top of patchback/backports/3.9/28d0b06c267335555f46569d0fd8803b74b1a5a4/pr-7902 Backporting merged PR #7902 into master
🤖 @patchback |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 28d0b06 on top of patchback/backports/3.10/28d0b06c267335555f46569d0fd8803b74b1a5a4/pr-7902 Backporting merged PR #7902 into master
🤖 @patchback |
(cherry picked from commit 28d0b06)
(cherry picked from commit 28d0b06)
Hopefully fixes the flakiness, by allowing a little extra time. Also improved the test by actually testing the client behaviour, and removing some calls which did nothing.