Devops: Add the slurm service to nightly workflow
#6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly worklow is configuring a computer that is using the `core.slurm` scheduler plugin, however, the container did not have a SLURM service running.
|
@sphuber I am wondering, shouldn't some of those warnings / errors fail the workflow? |
Perhaps. It is just that the nightly workflow just borrows the setup script with the main test workflow, but then it only executes a subset of tests, and these don't rely on this SLURM computer. So it failing didn't really matter either. If SLURM wouldn't have been installed for the container that runs the main tests, the tests would have errored because the computer would not be able to SLURM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly worklow is configuring a computer that is using the
core.slurmscheduler plugin, however, the container did not have a SLURM service running.