Fix REST API attributes_filter and extras_filter
#3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node_type had a final dot missing in the hard-coded mapping to generate the correct full types for process node namespaces of external plugins.
…_incorrect_full_type_mapping
Fixes aiidateam#3555. The REST API attributes_filter and extras_filter were not working correctly when pagination is requested. Without pagination they return attributes and extras dictionaries with the keys specified in attributes_filter and extras_filter as expected. When pagination is added they return instead the attributes keys as attributes.key, which is not consistent with the expected behavior.
|
Thanks! Could you add a test to check this please? |
|
@asle85 could you please still add the additional tests that we discussed? Then I can merge this and prepare the release. Thanks |
|
Improved tests on attributes_filter and extras_filter and added the two additional tests. |
sphuber
requested changes
Nov 22, 2019
aiida/backends/tests/test_restapi.py
Outdated
| ############### node get one attributes_filter with pagination ############# | ||
| def test_node_single_attributes_filter(self): | ||
| """ | ||
| Check that when only one node extra is specified in extras_filter |
There was a problem hiding this comment.
You still have "extra" twice in this docstring but should be "attribute".
There was a problem hiding this comment.
Sorry, fixed it.
Improved tests on attributes_filter and extras_filter with pagination. Added tests to check only one attribute or extra filter together with pagination.
…55_restapi_attributes_filter
elsapassaro
force-pushed
the
fix_3555_restapi_attributes_filter
branch
from
2a45827 to
55a1512
Compare
sphuber
approved these changes
Nov 22, 2019
|
Thanks @asle85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3555.
The REST API
attributes_filterandextras_filterwere not working correctly when pagination is requested.Without pagination they return attributes and extras dictionaries with the keys specified in
attributes_filterandextras_filteras expected.When pagination is added they return instead the attributes keys as
attributes.key, which is not consistent with the expected behaviour.Changed REST API version to 4.0.1.