Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc-Translate the Foundation page to French #904 #926

Merged
merged 8 commits into from
Jan 27, 2024
Merged

doc-Translate the Foundation page to French #904 #926

merged 8 commits into from
Jan 27, 2024

Conversation

geoffreylgv
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Documentation(i18n): Translate the Foundation page to French closes #904
Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 1:00pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 1:00pm

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-actions[bot]
github-actions bot reviewed Jan 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@geoffreylgv geoffreylgv mentioned this pull request Jan 27, 2024
Closed
2 tasks
@geoffreylgv
Copy link
Contributor Author

Overview of the french version

image

@coveralls
Copy link

coveralls commented Jan 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7678801545

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%
Totals Coverage Status
Change from base Build 7678749291: 0.0%
Covered Lines: 1257
Relevant Lines: 5082
💛 - Coveralls

@tobySolutions
Copy link
Contributor

Hey there, @geoffreylgv. Can you pull latest changes from main?

@geoffreylgv
Copy link
Contributor Author

Hey there, @geoffreylgv. Can you pull latest changes from main?

Ok

@tobySolutions
Copy link
Contributor

Hey there, @geoffreylgv. Can you pull latest changes from main?

Ok

Oh ok, awesome. Thanks. Push again after pulling the changes

@geoffreylgv
Copy link
Contributor Author

Hey there, @geoffreylgv. Can you pull latest changes from main?

Ok

Oh ok, awesome. Thanks. Push again after pulling the changes

All good now @tobySolutions

@tobySolutions
Copy link
Contributor

LGTM @geoffreylgv. Great work.

@tobySolutions tobySolutions merged commit 876e34a into aidenybai:main Jan 27, 2024
7 checks passed
@geoffreylgv
Copy link
Contributor Author

LGTM @geoffreylgv. Great work.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Documentation(i18n): Translate the Foundation page to French
4 participants
@geoffreylgv @CLAassistant @coveralls @tobySolutions