-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover & Focus state for Social Icons #670
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @tobySolutions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's the. advantage of the raw svg code over using React icons, please? @adetyaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can make the svgs an exportable component that you can come use here instead of having all the svg code be here; thank you.
Noted @tobySolutions I will do that and update. I used SVG because that was that's what I saw when digging through the Nextra documentation |
Awesome! Thanks. |
Oh, you haven't made the updates yet? |
Not yet, I'll be doing that soon. I'd like to know if I should create an icons folder in the components folder and put each one there since the have different svg values that can't be changed via props |
Any updates on this @adetyaz? |
Yes I'll be pushing my updates in about an hour, I was waiting for a response on the question I asked |
@tobySolutions It has been updated |
Can you please sign the CLA? @adetyaz |
Can you please point me to it @tobySolutions |
|
done @tobySolutions |
Awesome! Good job @adetyaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Please describe the changes this PR makes and why it should be merged:
This solve the issue #649
Status
Semantic versioning classification: