-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added guestbook #633
added guestbook #633
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!! @adhirajkar3103. One tiny thing though; could you try replacing the map with the <For/>
component?
https://million.dev/docs/for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used For component from million instead of map!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added Guestbook components in Kitchen Sink
Status
[ x] Code changes have been tested against prettier, or there are no code changes
[ x] I know how to update typings and have done so, or typings don't need updating
[x ] This PR changes the codebase
This PR only includes non-code changes, like changes to documentation, README, etc.