Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added guestbook #633

Merged
merged 2 commits into from
Oct 4, 2023
Merged

added guestbook #633

merged 2 commits into from
Oct 4, 2023

Conversation

adhirajkar3103
Copy link
Contributor

Added Guestbook components in Kitchen Sink

Status

  • [ x] Code changes have been tested against prettier, or there are no code changes

  • [ x] I know how to update typings and have done so, or typings don't need updating

  • [x ] This PR changes the codebase

    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • [ x] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:35am
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:35am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:35am

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!! @adhirajkar3103. One tiny thing though; could you try replacing the map with the <For/> component?
https://million.dev/docs/for

Copy link
Contributor Author

@adhirajkar3103 adhirajkar3103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used For component from million instead of map!

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants