Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: contexts #545

Merged
merged 6 commits into from
Aug 21, 2023
Merged

hotfix: contexts #545

merged 6 commits into from
Aug 21, 2023

Conversation

aidenybai
Copy link
Owner

@aidenybai aidenybai commented Aug 20, 2023

Please describe the changes this PR makes and why it should be merged:

This PR fixes contexts by reimplementing the root system to portal based system.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 0:58am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 0:58am

@aidenybai aidenybai changed the title feat: initial showcase page hotfix: contexts Aug 20, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5915301419

  • 7 of 256 (2.73%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 26.195%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/million/block.ts 5 9 55.56%
packages/compiler/react/transform.ts 2 247 0.81%
Totals Coverage Status
Change from base Build 5913624994: -0.5%
Covered Lines: 1271
Relevant Lines: 5044

💛 - Coveralls

Copy link
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that come to mind are:

  1. This approach might break SSR.
  2. This introduces the possibility of nested portals right? Do we need to avoid that scenario?

Otherwise generally this looks good, hard for me to examine in more detail without more test apps though.

@AbhiPrasad
Copy link
Contributor

Is there a way we can feature flag this to make it easier to test? Like we switch to the portal approach with an opt-in flag, ask people to test and then switch to this once we have more confidence.

@aidenybai aidenybai marked this pull request as ready for review August 20, 2023 23:17
Copy link
Contributor

@oliverloops oliverloops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the core block re-implementation and see everything fine, I just have a couple of questions around this portal based system:

  • What's the main purpose or migrate from the old one?
  • This could make harder to make it compatible with 3rd party UI libraries and the future cross file blocks feature?

@aidenybai
Copy link
Owner Author

going to run some beta tests

@aidenybai aidenybai merged commit f888809 into main Aug 21, 2023
@aidenybai aidenybai deleted the feat/context-support branch August 21, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants