Change reconstruction score to use change in means. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method of calculating takes the average of the case-by-case reconstruction score.
This seems wrong because it divides by the difference between the zero-ablation loss and the source loss which in some cases will be very close to zero, especially with models with more layers, and these cases will get large weight. Taking the average difference in loss seems more principled to me.
PR also changes the corresponding test.
Would like to test it to check that it reduces the noise but getting annoying wandb errors
"message":"Invalid sweep config: invalid hyperparameter configuration: source_data"at the moment.