Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of Mockito to make tests compatible with JDK 17+. #24

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

inigo
Copy link

@inigo inigo commented Apr 3, 2024

Tests currently pass with JDK 8/11, but fail with JDK 17+, because the Mockito version used is not compatible with newer JDKs.

This updates the version of Mockito to make tests compatible with JDK 17+ and switches from mockito-all to mockito-core - mockito-all is deprecated. Updated to mockito-core 4.x, because 5.x introduces changes that alter which method calls are detected and requires more extensive test changes.

Updated to latest 4.x, because 5.x introduces changes that alter which method calls are detected.
@agido-jrieks agido-jrieks self-assigned this Apr 4, 2024
Copy link
Collaborator

@agido-jrieks agido-jrieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

@agido-jrieks agido-jrieks merged commit 0942724 into agido-malter:staging Apr 4, 2024
3 checks passed
@agido-malter
Copy link
Owner

Thanks for your participation. New release made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants