Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wixtracts.ExtractFiles keeps msi Record handles open #84

Closed
ramiabughazaleh opened this issue Apr 5, 2017 · 1 comment
Closed

Wixtracts.ExtractFiles keeps msi Record handles open #84

ramiabughazaleh opened this issue Apr 5, 2017 · 1 comment
Milestone

Comments

@ramiabughazaleh
Copy link

Wixtracts.ExtractFiles keeps some msi Record handles open.

I ran into this issue when I was directly calling Wixtracts.ExtractFiles and then when it was finished, immediately trying to open the msi file for writing.
In my case, for reference, I received the following exception:
System.IO.FileLoadException: The process cannot access the file because it is being used by another process. (Exception from HRESULT: 0x80070020)

I debugged the issue and it's because the Record objects are not being closed until they are garbage collected which may be some time in the future.

I will create a pull request.

Thank you.

ramiabughazaleh pushed a commit to ramiabughazaleh/lessmsi that referenced this issue Apr 5, 2017
@activescott
Copy link
Owner

Thanks so much for the PR @ramiabughazaleh . I'll try to get this tested on my side, merged, and into a release asap.

activescott added a commit that referenced this issue Apr 13, 2017
@activescott activescott added this to the v1.6.1 milestone Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants