-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy-load rails interactions #456
Conversation
Surprising this hasn't come up before. Thanks! Tests are running now. |
Hey @javierjulio I think I fixed the build. This problem surfaced when I tried to use I think the next version of Rails is going to be strict about gems that are inadvertently loading Rails concerns without using load hooks: rails/rails#46047 |
@javierjulio @deivid-rodriguez please let me know if I need to do anything else to get this merged and released. Happy to help! |
@javierjulio @deivid-rodriguez just wanted to kindly bump this 🙇 |
@ngan I will get to this soon, thank you. |
9f3a4a4
to
0f43111
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 91.36% 91.66% +0.29%
==========================================
Files 17 17
Lines 475 480 +5
==========================================
+ Hits 434 440 +6
+ Misses 41 40 -1
☔ View full report in Codecov by Sentry. |
0f43111
to
a19592e
Compare
a19592e
to
7d4ae0f
Compare
@javierjulio this is ready for another look! 🙇 |
250063d
to
5478006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thus PR does a few things:
lib/rails.rb
tolib/railtie.rb
to follow modern conventions.action_view
loading. Only then do we want to register the template handler.send :include
to justinclude
since this gem supports only version of Ruby where it’s a public method.The way it's current done is problematic for me because it attempts to reference
ActionView
before it's loaded by the application itself (config/application.rb
). Requiring therails
gem doesn't actually load all the rails gems.